-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IJ indices for stretched grid and bubble up error from MAPL_getHorzIJindex subroutine #2851
base: develop
Are you sure you want to change the base?
Conversation
The main problem is, if we commit this, then we can't run the stretched grid with GOCART, right? And, well, I'm not sure if that's desired. We might need to support some sort of "slower"/"dumber" IJ method if running stretched grid. |
I've drafted this PR until @tclune can have a think on it as well. |
This PR has been automatically marked as stale because it has not had activity in the last 60 days. If there are no updates within 7 days, it will be closed. You can add the ":hourglass: Long Term" label to prevent the stale action from closing this issue. |
…PL into feature/wjiang/ijindex_error
I can confirm this definitely works! I ran a stretched case and failed as expected. |
Hmm. GNU is not happy:
|
The function for reverse Schmidt transform is added and the indices can be calculated now. But I have not run the gcm with stretched grid. How can I do the setup and run? @mathomp4 |
@weiyuan-jiang My makeoneday script should work for c270 or c540. Just choose Ostia-CS ocean as well. |
keep the types of "sign" arguments consistent
I just tried a C270 run and:
and I also saw:
|
Oh yes. The pi/18 shift does not happen for the stretched grid. ... |
This PR also addresses issue #3060 |
Types of change(s)
Checklist
make tests
)Description
Stop the program when the grid is not a normal CS grid but computes the IJindex. It partially addresses issue #2850 . Eventually, I think the Grid class should have information about stretch and the ij index is computed according to the info the grid provides
Related Issue